Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(appengine-pubsub):ava to mocha #1225

Merged
merged 2 commits into from
Mar 27, 2019
Merged

refactor(appengine-pubsub):ava to mocha #1225

merged 2 commits into from
Mar 27, 2019

Conversation

AVaksman
Copy link
Contributor

Towards #1080
Taking over PR #1181

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 26, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 26, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Mar 26, 2019

Thanks! Made you a collaborator so you can add the kokoro label to start the tests. Let me know if there's anything else I can do to help.

@AVaksman AVaksman added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 26, 2019
@AVaksman AVaksman added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 26, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 26, 2019
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2019
@AVaksman
Copy link
Contributor Author

Thanks! Made you a collaborator so you can add the kokoro label to start the tests. Let me know if there's anything else I can do to help.

Thanks!

@AVaksman
Copy link
Contributor Author

@fhinkel
It looks like appengine/pubsub tests are passing.
Is(are) the failing test(s) something unrelated?
I tried force-starting/running a couple of times, but there is always one that fails 😟

@fhinkel
Copy link
Contributor

fhinkel commented Mar 27, 2019

The dialogflow tests don't pass yet, unrelated. Sorry for the confusion.

fhinkel
fhinkel approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fhinkel fhinkel merged commit 5d8904f into GoogleCloudPlatform:master Mar 27, 2019
@AVaksman AVaksman mentioned this pull request Mar 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AVaksman @fhinkel @googlebot @kokoro-team